feat: seperate decryption domains #2690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new build-time-env `ROUTER_TYPE` defaults to 'hash' with optional 'history' value to use the browsers history api for routing. Also refactor Dockerfile to improve performance on subsequent builds.
Add new env PUBLIC_DECRYPTION_URL to change the base-url used for decryption.
Patrick-Remy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In some scenarios you might have a different domain used for public decryption.
Hint: This Pull request is based on #2689 and is also related to #1635
Implemented solution
New built-time env
PUBLIC_DECRYPTION_URLis added to adjust the frontend-presented domain for decryption.