Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display filter rank options in frontend #11910

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

renanfranca
Copy link
Contributor

@renanfranca renanfranca commented Feb 14, 2025

A demo video of the implemented feature:

20250214-rank_filter_demo.mp4

There were many things going on in the above demo video so I will list the completed tasks below.

Rank Module Filter Implementation Tasks

UI Components

  • Create LandscapeRankModuleFilterVue component with:
    • Rank filter buttons for all RANKS
    • Active state styling for selected rank
    • Title attributes with rank descriptions
    • Disabled state for ranks without modules
    • Click handlers for selection/deselection

Rank Filtering Logic

  • Implement rank filtering in the Landscape class:
    • filterByRank() method
    • Module visibility based on selected rank
    • Dependency handling for modules with different ranks
    • Feature preservation when containing filtered modules

Module Emphasis

  • Add minimal emphasis styling for:
    • Dependency modules with different ranks than filter
    • Features containing modules with different ranks

Integration

  • Connect rank filter to Landscape component:
    • Do not show rank filter on small screens
    • Emit selected rank event
    • Update Landscape display with filtered modules
    • Handle preset interactions when the rank filter changes

Design

  • Create tikui toggle-button atom
  • Create tikui landscap-rank-module-filter organism

The dark mode Landscape screen with rank module filter

2025-02-14 10 53 26 localhost 05a23467da33

@renanfranca renanfranca force-pushed the 10934-display-filter-rank-options-in-frontend branch from b2c4106 to 7798657 Compare February 14, 2025 17:23
@renanfranca renanfranca marked this pull request as ready for review February 14, 2025 17:37
@renanfranca
Copy link
Contributor Author

@qmonmert: Thank you for the review. I have pushed the fixes. Let me know if you need some changes ✌️

Copy link
Contributor

@qmonmert qmonmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New state for modules
2 participants