fix: Temporary fix for JingleSession-s being GC too early (#1019)

JingleSessions register with JingleIqHandler which saves a weak reference and there are no other references to the object until the session is accepted and saved as Participant.jingleSession. If the weak reference expires before session-accept is received the session fails to establish. This is a quick and dirty fix, a proper solution will follow later.
jitsi · Dec 7, 2022 · 7f90049 · 7f90049
1 parent fe8c958
commit 7f90049
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/jicofo/src/main/java/org/jitsi/jicofo/conference/ParticipantInviteRunnable.java b/jicofo/src/main/java/org/jitsi/jicofo/conference/ParticipantInviteRunnable.java
@@ -387,6 +387,8 @@ private boolean doInviteOrReinvite(Offer offer, ColibriAllocation colibriAllocat
                 jingleSession.terminate(Reason.UNDEFINED, null, false);
             }
             jingleSession = participant.createNewJingleSession();
+            // Save a reference to jingleSession to prevent it from being garbage collected. Temporary fix!
+            participant.setJingleSessionTmp(jingleSession);
             logger.info("Sending session-initiate to: " + participant.getMucJid() + " sources=" + sources);
             ack = jingleSession.initiateSession(
                     offer.getContents(),

diff --git a/jicofo/src/main/kotlin/org/jitsi/jicofo/conference/Participant.kt b/jicofo/src/main/kotlin/org/jitsi/jicofo/conference/Participant.kt
@@ -80,6 +80,9 @@ open class Participant @JvmOverloads constructor(
         addContext("participant", endpointId)
     }
 
+    // Save a reference to jingleSession to prevent it from being garbage collected. Temporary fix!
+    var jingleSessionTmp: JingleSession? = null
+
     /**
      * The layer which keeps track of which sources have been signaled to this participant.
      */