Post debug extras - #219
Open
paweldomas wants to merge 2 commits into
Open
Conversation
This allows to share session specific variables between session related instances.
paweldomas
force-pushed
the
post-debug-extras
branch
from
January 9, 2020 22:32
ad02a22 to
b92d6f9
Compare
nikvaessen
approved these changes
Jan 10, 2020
| * The logger for this class | ||
| */ | ||
| private final static Logger logger | ||
| = Logger.getLogger(GoogleCloudTranscriptionService.class); |
Contributor
There was a problem hiding this comment.
Change the logger name?
| @Override | ||
| public void onCompleted() | ||
| { | ||
| for(TranscriptionListener listener : requestManager.getListeners()) |
Contributor
There was a problem hiding this comment.
I think it would be valuable to trace what listeners have been to stop or whether whether the list of listeners is empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is two extra commits added on top of #218 but it's a big change and not sure if desired.