feat(transcription): add OCI Speech model domain config support (GENERIC/MEDICAL) - #642
Open
felipeavilis wants to merge 1 commit into
Open
feat(transcription): add OCI Speech model domain config support (GENERIC/MEDICAL)#642felipeavilis wants to merge 1 commit into
felipeavilis wants to merge 1 commit into
Conversation
…RIC/MEDICAL) Adds a new configuration property to OracleTranscriptionService that allows selecting the OCI Speech Realtime API model domain: org.jitsi.jigasi.transcription.oci.modelDomain=MEDICAL Accepted values are GENERIC (API default, used when unset) and MEDICAL. The MEDICAL domain improves accuracy on healthcare terminology. Logs a warning when MEDICAL is configured with a non-English locale, since the OCI MEDICAL model only supports English (en-*).
Member
|
Hi, thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #642 +/- ##
============================================
- Coverage 19.11% 18.76% -0.36%
+ Complexity 310 302 -8
============================================
Files 84 84
Lines 7223 7236 +13
Branches 958 962 +4
============================================
- Hits 1381 1358 -23
- Misses 5612 5651 +39
+ Partials 230 227 -3
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for selecting the OCI Speech Realtime API model domain in
OracleTranscriptionServicevia a new configuration property:org.jitsi.jigasi.transcription.oci.modelDomainGENERIC(API default, unchanged behavior when unset) orMEDICALMEDICALdomain improves transcription accuracy on healthcare terminologyMEDICALis configured with a non-English locale, since the OCI MEDICAL model only supports English (en-*)Configuration
Add to
sip-communicator.properties:Evidence
Successful connection with
modelDomain=MEDICALanden-USExpected failure with
modelDomain=MEDICALandpt-BR(OCI does not support MEDICAL for non-English)The warning introduced in this PR surfaces this misconfiguration before the API rejects the connection.
Test plan
mvn install -DskipTests)mvn checkstyle:check)mvn test)modelDomain=MEDICAL+languageCode=en-US— connection established and transcription receivedpt-BR+MEDICALproduces a 400 from the API (expected — OCI limitation)modelDomainquery parameter sent)