Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moment duration format error #14190

Merged
merged 4 commits into from
Jan 8, 2024
Merged

fix: moment duration format error #14190

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a8fe45
fix: moment duration format error
oguzhanslmtemiz Dec 28, 2023
4d9e3cb
fix: linter errors
oguzhanslmtemiz Jan 8, 2024
132a21c
chore: match dependency version exactly
oguzhanslmtemiz Jan 8, 2024
330c9c7
chore: match dependency version exactly
oguzhanslmtemiz Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion react/features/base/i18n/dateUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
import i18next from './i18next';

// allows for moment durations to be formatted
import 'moment-duration-format';
import momentDurationFormatSetup from "moment-duration-format";

Check failure on line 6 in react/features/base/i18n/dateUtil.ts

View workflow job for this annotation

GitHub Actions / Lint 

`moment-duration-format` import should occur before import of `./i18next`

Check failure on line 6 in react/features/base/i18n/dateUtil.ts

View workflow job for this annotation

GitHub Actions / Lint 

Strings must use singlequote
momentDurationFormatSetup(moment);

// MomentJS uses static language bundle loading, so in order to support dynamic
// language selection in the app we need to load all bundles that we support in
Expand Down
Loading