feat(systemd): use native template units for prosody visitor instances

[srijan2607]

This pull request updates the way multiple Prosody instances are managed for extra-large conference deployments by switching from per-instance systemd unit files to a single systemd template unit. This simplifies configuration, reduces duplication, and standardizes service management commands. The most important changes are grouped below:
Related issue: #16654

Systemd service management improvements:

• Replaced the creation of individual prosody-vN.service files with a single systemd template unit file [email protected], using %i as the instance placeholder throughout the unit configuration. (resources/extra-large-conference/[email protected], [1] [2] [3]
• Updated the script to copy the template unit file once, instead of generating a separate unit file for each instance. (resources/extra-large-conference/pre-configure.sh, resources/extra-large-conference/pre-configure.shR19-L23)
• Changed service restart commands to use systemctl restart [email protected] for each instance and systemctl restart jicofo.service, aligning with modern systemd practices. (resources/extra-large-conference/pre-configure.sh, resources/extra-large-conference/pre-configure.shL59-R62)

Configuration simplification:

• Removed the need to perform sed replacements on unit files, as the template unit now handles instance-specific configuration via %i. (resources/extra-large-conference/pre-configure.sh, resources/extra-large-conference/pre-configure.shR19-L23)

These changes make managing multiple Prosody instances more maintainable and consistent.

[srijan2607]

@saghul can you review the changes ?

[jitsi-jenkins]

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

[stokito]

It looks like we can restart all services by systemctl restart prosody-v@*

[srijan2607]

Agreed this will removes the redundant loop and uses one command to restart all instances.

[stokito]

jicofo.service can be just jicofo

[stokito]

It's better to save it to the /usr/lib/systemd/system/[email protected], not just /lib.

[srijan2607]

@stokito i have made the the suggested changes

[srijan2607]

@damencho can you please take a look at this

[saghul]

LGTM, but I also want @damencho to take a look.

[damencho]

On a running system where I have prosody-v0 installed and running I did:

cp [email protected] /usr/lib/systemd/system/[email protected]
systemctl restart 'prosody-v@*.service'

And it did not restart my prosody-v0.

[stokito]

systemctl daemon-reload should be executed after installing the service file

[damencho]

Still nothing

[stokito]

Check what shows the sudo systemctl status postgresql@*
Check of these services are recognized systemctl list-units | grep prosody

[damencho]

Check of these services are recognized systemctl list-units | grep prosody

Yeah, seems it is not correct on my end. Will continue testing and will let you know how it goes.

[srijan2607]

@damencho @stokito Thanks for testing! I've identified and fixed the issue.

Cause

The template instances were never created or started. The script only copied the template file and created config directories, but never told systemd to actually start the service instances.

Changes

1. Added daemon-reload after copying template:

cp [email protected] /usr/lib/systemd/system/[email protected]
systemctl daemon-reload

2. Added instance creation in the config loop:

for (( i=1 ; i<=${NUMBER_OF_INSTANCES} ; i++ )); do
    # ... config creation ...
    systemctl enable --now prosody-v@${i}.service  # Creates and starts each instance
done

3. Reverted to explicit restart loop:

for (( i=1 ; i<=${NUMBER_OF_INSTANCES} ; i++ )); do
  systemctl restart prosody-v@${i}.service
done

The wildcard prosody-v@*.service doesn't work because no instances exist yet to match. The enable --now command is what actually instantiates the template into running services.

@damencho Could you please test again? Running systemctl list-units | grep prosody should now show all instances as active and running.

[srijan2607]

@damencho can you please test it again