cli/tests: move a lot of the cli tests to gitoxide #5575 #5639
+1,172
−882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mod.rs` was becoming crowded and this makes way for unrelated additions to the test utilities module
bsdinis
commented
Feb 10, 2025
bsdinis
force-pushed
the
bsdinis/srruzkxpyysz
branch
4 times, most recently
from
93c3b4e to
69ad9c8
Compare
7 tasks
bsdinis
force-pushed
the
bsdinis/srruzkxpyysz
branch
from
69ad9c8 to
c7b4f17
Compare
cargo-insta was re-run. This is due to centralizing git interaction code to use a particular different signature, which changes the commit hashes
cargo-insta was re-run. This is due to centralizing git interaction code to use a particular different signature, which changes the commit hashes
bsdinis
force-pushed
the
bsdinis/srruzkxpyysz
branch
from
c7b4f17 to
b4b9915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In keeping with #5548 , this moves a lot of the current
clitests togitoxide.This doesn't do it all. but thought it best to send this as is, as there is a lot of code to review already (even though most of it is relatively straightforward). Nevertheless, this is what is missing:
gix#5553 is merged we can use that machinery directly hereThis PR also consolidates a lot of what was copy pasted code (namely creating new repos and adding commits to it). This, plus
gitoxide's idiosyncrasies make most of the git hashes in the tests change, hencecargo-instawas run in a separate commit to avoid the noise.The new gitoxide helpers in
cli/tests/common/git.rshelp centralize a lot of common functionality, and make sure we don't run into GitoxideLabs/gitoxide#1829.Overall, this PR has a lot of commits to help reviewing, but at the end of the day, I think the commit structure should be:
This PR was originally #5575 but Github exists to make my life miserable and I unwittingly removed the branch the PR was based on