Pass null for cache parameter to disable caching

jlevers · Jun 24, 2024 · f77901d · f77901d
1 parent 285ab2f
commit f77901d
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 4 deletions.
diff --git a/src/SellingPartnerApi.php b/src/SellingPartnerApi.php
@@ -330,13 +330,18 @@ protected function createOAuthAuthenticator(string $accessToken, ?DateTimeImmuta
 
     protected function getCacheableAuthenticator(string $key, callable $refetch): AccessTokenAuthenticator
     {
-        $cached = $this->cache->get($key);
-        if ($cached) {
-            return $cached;
+        if ($this->cache) {
+            $cached = $this->cache->get($key);
+            if ($cached) {
+                return $cached;
+            }
         }
 
         $fetched = $refetch();
-        $this->cache->set($key, $fetched);
+
+        if ($this->cache) {
+            $this->cache->set($key, $fetched);
+        }
 
         return $fetched;
     }

diff --git a/tests/AuthenticationTest.php b/tests/AuthenticationTest.php
@@ -388,4 +388,31 @@ public function testFetchesTokenFromCache(): void
         // Make sure different dataElements sets result in different RDTs
         $this->assertNotEquals($dataElementsRdtAuthenticator1->accessToken, $dataElementsRdtAuthenticator2->accessToken);
     }
+
+    public function testWorksWithNoCache(): void
+    {
+        $faker = Faker\Factory::create();
+        $mockClient = new MockClient([
+            GetAccessTokenRequest::class => fn () => MockResponse::make([
+                'access_token' => $faker->unique()->asciify('********************************************'),
+                'token_type' => 'bearer',
+                'expires_in' => 3600,
+                'refresh_token' => 'refresh-token',
+            ]),
+        ]);
+
+        $connector = SellingPartnerApi::seller(
+            clientId: 'client-id',
+            clientSecret: 'client-secret',
+            refreshToken: 'refresh-token',
+            endpoint: Endpoint::NA_SANDBOX,
+            cache: null,
+        );
+        $connector->withMockClient($mockClient);
+
+        $authenticator1 = $connector->defaultAuth();
+        $authenticator2 = $connector->defaultAuth();
+
+        $this->assertNotEquals($authenticator1->accessToken, $authenticator2->accessToken);
+    }
 }