fix: support dynamic modules in CommandFactory
#1229
+83
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CommandFactory.run()` already supports running dynamic modules, but the type `Type<any>` doesn't allow passing `DynamicModule`.
🦋 Changeset detectedLatest commit: f2d6228 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
johnnyomair
commented
Feb 12, 2025
| @@ -9,8 +9,9 @@ layout: ../../layouts/MainLayout.astro | |||
|
|
|||
| #### @Command() | |||
|
|
|||
| This class decorator is pretty much what everything else in this package relies on existing. This is | |||
| the decorator that sets up the sub commands for the application that are to be consumed. | |||
| This class decorator is pretty much what everything else in this package relies | |||
There was a problem hiding this comment.
I don't know why this changes, probably related to Prettier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandFactory.run()already supports running dynamic modules, but the typeType<any>doesn't allow passingDynamicModule.