feat: add support for convertible map keys #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddycharly
force-pushed
the
fix-convertible-types
branch
from
7480783 to
d5262d4
Compare
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
eddycharly
force-pushed
the
fix-convertible-types
branch
from
d5262d4 to
dccfd31
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 88.51% 90.77% +2.26%
==========================================
Files 15 15
Lines 2594 2212 -382
==========================================
- Hits 2296 2008 -288
+ Misses 204 112 -92
+ Partials 94 92 -2 ☔ View full report in Codecov by Sentry. |
eddycharly
force-pushed
the
fix-convertible-types
branch
from
a9bfdc5 to
e29b48c
Compare
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
eddycharly
force-pushed
the
fix-convertible-types
branch
from
e29b48c to
562fa04
Compare
|
@springcomp PTAL :) |
|
It looks good ! |
springcomp
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for convertible map keys.