Tests for bugfixes provided in PRs # 33 and #34 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function was broken since con.features.__dict__.get() isn't guaranteed that it will get real feature value. For example, 'django.db.backends.BaseDatabaseFeatures#supports_transactions' is implemented as a 'cached_property'. The 'cached_property' decorator is implemented as a descriptor that replaces itself on the instance with computed value after first call - it means that prior to first call instance it is attached to has no value for target field. TL;DR: Added support for feature fields based on descriptors.
…on does not re-raises exception that caused this method being called.
…s bugfix provided in PR#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: