Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Request.sign() option to omit oauth_body_hash #103

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Request.sign() option to omit oauth_body_hash #103

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5cd87c
Added an option to exclude oauth body hash from headers
bensonk Jan 10, 2012
5c8c239
add include_body_hash parameter when calling sign_request from within…
tomds Feb 15, 2012
87310bb
Merge pull request #1 from tomds/master
bensonk Feb 15, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions oauth2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,10 +481,10 @@ def get_normalized_parameters(self):
# Spaces must be encoded with "%20" instead of "+"
return encoded_str.replace('+', '%20').replace('%7E', '~')

def sign_request(self, signature_method, consumer, token):
def sign_request(self, signature_method, consumer, token, include_body_hash=True):
"""Set the signature parameter to the result of sign."""

if not self.is_form_encoded:
if not self.is_form_encoded and include_body_hash:
# according to
# http://oauth.googlecode.com/svn/spec/ext/body_hash/1.0/oauth-bodyhash.html
# section 4.1.1 "OAuth Consumers MUST NOT include an
Expand Down Expand Up @@ -637,7 +637,7 @@ def set_signature_method(self, method):
self.method = method

def request(self, uri, method="GET", body='', headers=None,
redirections=httplib2.DEFAULT_MAX_REDIRECTS, connection_type=None):
redirections=httplib2.DEFAULT_MAX_REDIRECTS, connection_type=None, include_body_hash=True):
DEFAULT_POST_CONTENT_TYPE = 'application/x-www-form-urlencoded'

if not isinstance(headers, dict):
Expand All @@ -659,7 +659,7 @@ def request(self, uri, method="GET", body='', headers=None,
token=self.token, http_method=method, http_url=uri,
parameters=parameters, body=body, is_form_encoded=is_form_encoded)

req.sign_request(self.method, self.consumer, self.token)
req.sign_request(self.method, self.consumer, self.token, include_body_hash=include_body_hash)

schema, rest = urllib.splittype(uri)
if rest.startswith('//'):
Expand Down