Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer verifier Sui changes #3

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Transfer verifier Sui changes #3

merged 1 commit into from
Nov 15, 2024

Conversation

mdulin2
Copy link

@mdulin2 mdulin2 commented Oct 22, 2024

Mostly just adding tests for Sui Transfer verification. I made a few small changes though:

  • ObjectChanges are no longer additive. Just in case the Sui API returns the same object twice we don't want to count them more than once.
  • Made the ObjectType regex more strict by adding ^ and $.
  • Changed totalSupply to a bigInt.

@johnsaigle johnsaigle merged commit d1b8878 into johnsaigle:transfer-verifier Nov 15, 2024
19 of 24 checks passed
johnsaigle pushed a commit that referenced this pull request Nov 22, 2024
@mdulin2 @johnsaigle
Sui transfer verification tests (#3)
a87cfd2 
Co-authored-by: Maxwell Dulin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdulin2 @johnsaigle