Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tagList instead of fluidPage #9

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tylerlittlefield
Copy link

@tylerlittlefield tylerlittlefield commented Dec 15, 2020

Removes the 15px padding on the left and right sides of the app.

I noticed the .Rprofile was either removed or renamed to .Rprofile.example but that might need to be reversed. The renv stuff will no longer be sourced on a fresh R session, so developers will need to do it manually if deploying that app locally on their own computer.

@doug-friedman
Copy link
Collaborator

doug-friedman commented Dec 16, 2020

So @tyluRp tagList is fluidPage without a bunch of the bootstrap styling hooks, right? I'm looking at the source code and that's what it seems like.

@CCorrado
Copy link
Collaborator

@doug-friedman @tyluRp the .Rprofile file is in the repository as .Rprofile.example to fix an issue with deployment. Locally, .Rprofile is ignored so developers wishing to create a local env can safely copy .Rprofile.example to their local .Rprofile without affecting their commits or the deployment.

Ref: rstudio/renv#453

@tylerlittlefield
Copy link
Author

@CCorrado Got it!

@doug-friedman Exactly!

library(shiny)

fluidPage(
  fluidRow()
)

#> <div class="container-fluid">
#>   <div class="row"></div>
#> </div>

tagList(
  fluidRow()
)

#> <div class="row"></div>

@tylerlittlefield
Copy link
Author

Also, I wonder what would happen if the .Rprofile was instead written as:

if (interactive()) source("renv/activate.R")

I have no idea if interactive would return TRUE or FALSE during the deployment though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants