Named attachements #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sata51
force-pushed
the
named-attachements
branch
from
fdc54c0 to
b6eac76
Compare
|
Hi @Sata51, This LGTM but could you do me a favor and add a test that confirms the behavior is working as expected? Thanks! |
|
I've done it :D |
* Support UTF-8 in email subject Was trying to import that email sample from https://cdn.online-convert.com/example-file/document/eml/example.eml into GoPhish but the subject is just displayed as "=?UTF-8?Q?_EML Example File?=". The patch is adding UTF-8 support for the subject string. * Support for more non-ASCII text in headers According to RFC2047 non ascii text is also allowed in other fields like From, To, ... * Add test function for non ascii email parsing
|
I was about to push a branch with this exact change. It's pretty essential since most files on servers have crazy names with timestamps lol |
Removing comments that don't add significantly useful context.
I counted the fields being set and they are generally more than four items.
Pin the expected compiler version. This shouldn’t break backwards compatibility.
Adds support for mime/related HTML attachments.
Co-authored-by: hala alajlan <[email protected]>
Initial commit of GitHub Actions for CI Testing
If the part has the header 'Content-Disposition' with a value of 'attachment' then add the part as an attachment to the Email.
A bug was introduced in 27742b0 where, in the process of trying to add TLS support, broke the way the connection is set up since it still tried to use `STARTTLS` under the hood. Fixes jordan-wright#71.
* Format From, To, Cc & Bcc for RFC1342 * Fixed seperator & added tests
|
@jordan-wright could you may take a look at this again? |
|
@Sata51 could you fix the conflicts? |
|
@fank fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to attach a file with a custom file name
Instead of using the default:
you can provide a custom named file using this: