Fix set_learning_rate_lstm bug refered issued #64

josephjaspers · May 7, 2020 · 87e9749 · 87e9749
1 parent ec7ac8d
commit 87e9749
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/blackcat/neural_networks/layers/lstm.h b/blackcat/neural_networks/layers/lstm.h
@@ -311,7 +311,6 @@ struct LSTM:
 	virtual
 	void set_learning_rate_hook(value_type lr) override final
 	{
-		parent_type::set_learning_rate(lr);
 		value_type batched_lr = this->get_batched_learning_rate();
 
 		auto optimizers = enumerate(

diff --git a/examples/mnist_test_recurrent/mnist_test.h b/examples/mnist_test_recurrent/mnist_test.h
@@ -22,20 +22,22 @@ int percept_MNIST(System system_tag, std::string mnist_dataset,
 		bc::nn::logging_output_layer(system_tag, 10, bc::nn::RMSE).skip_every(100)
 	);
 
-	auto lstm = bc::nn::lstm(system_tag, 784 / 4, 128);
-	lstm = lstm;
-	auto ff = bc::nn::feedforward(system_tag, 64, 10);
-	ff = ff; 
-	auto softmax = bc::nn::softmax(system_tag, 10);
-	softmax = softmax; 
 
 	//Regression-test to ensure compilation 
-	if (false)
-		network = network; 
+	if (false) {
+		auto lstm = bc::nn::lstm(system_tag, 784 / 4, 128);
+		lstm = lstm;
+		auto ff = bc::nn::feedforward(system_tag, 64, 10);
+		ff = ff;
+		auto softmax = bc::nn::softmax(system_tag, 10);
+		softmax = softmax;
+		network = network;
+	}
 
 	bc::print("Neural Network architecture:");
 	bc::print(network.get_string_architecture());
 
+	network.set_learning_rate(.003);
 	network.set_batch_size(batch_size);
 
 	std::pair<cube, cube> data = load_mnist(