Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8+ versions and fix for namespace/class collision #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ttodua
Copy link

@ttodua ttodua commented Jun 6, 2021

No description provided.

ttodua added 2 commits June 7, 2021 00:39
Without these changes, multi-curl does not work with PHP 8, as CurlHandle is no longer a resource (thus, can't be converted into string for key-purposes)
@ttodua
Copy link
Author

ttodua commented Jun 6, 2021

@joshfraser Hi Josh.
Just 60 seconds will be enough to review this PR.
Please do whenever you can.

@speich
Copy link

speich commented Jul 8, 2021

I suggest using the php8 function get_resource_id() instead

@speich
Copy link

speich commented Jul 8, 2021

never mind, works on resources not instances, but you could use spl_object_hash()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants