refactor: add tests, implement more markdown features, don't panic for unimplemented features #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
force-pushed
the
jm/add-tests
branch
from
8cdbcb4 to
6ecb552
Compare
joshka
force-pushed
the
jm/add-tests
branch
from
6ecb552 to
001bd93
Compare
joshka
changed the title
joshka
force-pushed
the
jm/add-tests
branch
from
001bd93 to
054b00e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 0.00% 37.66% +37.66%
==========================================
Files 7 5 -2
Lines 492 446 -46
==========================================
+ Hits 0 168 +168
+ Misses 492 278 -214 ☔ View full report in Codecov by Sentry. |
- Adds tests - Removes the need for a temporary line (as the last line in the text can be used) - Properly handles the right number of linebreaks - Handles lists properly - ignores unimplemented features rather than panicking
joshka
force-pushed
the
jm/add-tests
branch
from
054b00e to
098781b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests and refactors the code
The main change is removing the temporary line and just treating the last line in the text as the temporary line.
The second major change is moving to more stack based handling of styles, prefixes etc.
There is also much better logging, which will likely be tweaked for verbosity, but I'm finding it useful to use this for writing a test, reading the logs then implementing the changes to satisfy the test.
Items that are not yet implemented are ignored now rather than panicking.