-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactored the Newsletter and User Controller
-Merged index, opt_in and opt_out actions from newsletter controller. -Moved sendtest, sendmailer and testmail actions from user controller to newsletter controller. -Merged test_opt_in, test_opt_out and testmail(from user controller) actions and renamed it as test_mail. -Merged send_opt_in_test, send_opt_out_test and sendtest(from user controller) actions and renamed it as send_test_mail. -Merged send_opt_in, send_opt-out and sendmailer(from user controller) actions and renamed it as send_newsletter. -Romoved the global send mail and send test buttons and added buttons below individual newsletters. -Removed the unnecessary and added necessary routes. -Added before filters and flash messages in Newsletter and User controller -Added method in before filter of newsletter controller -Added load_user before filter in user controller -Added flash messages where required -Added alert message before deleting newsletter -Modified the UI for test mail template and changed flash messages -Added placeholder to email_ids field in test mail template -Changed flash messages for test mail -Modified the UI and added type parameter in newsletters path -Added type in newsletters_path -Handled a failure condition - absence of newsletter in params -Changed the UI for test mail template -Changed the query for fetching newsletter in opt-in worker, opt-out worker and user worker -Added type varible for redirect path -Fix test configuration -Fix the bootstrap navbar menu-items active-state issue -Corrected the spelling and removed the type from flash messages -Fix the gemfile for test environment -Added Test cases for updated code -Added test cases for send newsletter and send test mail in newsletter controller spec -Added test cases for opt in, opt out and get image in newsletter model spec -Removed test cases for send_mailer and sendtest from user controller spec -Fixed typo in Rakefile -Updated load_newsletter query -Handled failure cases for update and destroy action of newsletter controller -Modified testcases to check flash message content -Added more checks and Moved instance varible from before filter to respective test case -Replaced double quotes with single quotes -Minor syntax corrections -Fixed the query for load newsletter and minor syntax error in user index template -Removed duplicated methods
- Loading branch information
1 parent
4d3bea6
commit 97b6e04
Showing
31 changed files
with
587 additions
and
385 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.