Calendar: Add working year / month select demo#1803
Merged
fnagel merged 4 commits intojquery:datepickerfrom May 17, 2017
Merged
Calendar: Add working year / month select demo#1803fnagel merged 4 commits intojquery:datepickerfrom
fnagel merged 4 commits intojquery:datepickerfrom
Conversation
scottgonzalez
suggested changes
Apr 11, 2017
Member
scottgonzalez
left a comment
scottgonzalez
left a comment
There was a problem hiding this comment.
Let's do this as an extension instead and add the old options back.
| return title | ||
| .append( month ) | ||
| .append( " " ) | ||
| .append( year ); |
Member
There was a problem hiding this comment.
Isn't this order locale specific?
| changeYear: true | ||
| $.widget( "custom.calendarWithSelect", $.ui.calendar, { | ||
| _buildTitle: function() { | ||
| var title = $( "<div>", { role: "alert", id: this.gridId + "-month-label" } ), |
Member
There was a problem hiding this comment.
Hmm...Can we come up with a way to avoid using internal properties like this.gridId?
| } | ||
| } ); | ||
|
|
||
| for ( ;i < 12; i++ ) { |
fnagel
force-pushed
the
datepicker-month-year-select
branch
from
ce6f34a to
2ac81ad
Compare
fnagel
force-pushed
the
datepicker-month-year-select
branch
from
2ac81ad to
d6de67a
Compare
Member
Author
|
@scottgonzalez Updated the branch. Please review! Tests fail again, but this time I'm not able to reproduce it locally :-/ |
scottgonzalez
approved these changes
Apr 17, 2017
Member
scottgonzalez
left a comment
scottgonzalez
left a comment
There was a problem hiding this comment.
I'm fine with merging this even with the failing test since we have a plan to address that. You can just comment out that test for now so that we can identify new failures easily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.