Calendar: Create helper methods for Date object creation#1818
Merged
fnagel merged 1 commit intojquery:datepickerfrom May 28, 2017
Merged
Calendar: Create helper methods for Date object creation#1818fnagel merged 1 commit intojquery:datepickerfrom
fnagel merged 1 commit intojquery:datepickerfrom
Conversation
scottgonzalez
approved these changes
May 17, 2017
|
|
||
| return $.extend( helper, { | ||
| createDate: function( year, month, day ) { | ||
| if ( arguments.length === 1 ) { |
Member
There was a problem hiding this comment.
We shouldn't need to worry about this case for timezone correction, but having all dates go through the helper does make it easier to reason about in the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract all
new Date()occurrences in order to simplify a possible fix for our unit test timezone issue.