Build: Migrate from JSHint & JSCS to ESLint#1958
Merged
mgol merged 4 commits intojquery:mainfrom Jun 6, 2021
Merged
Conversation
Member
As long as the new ESLint runs with each build (and here in the GitHub / CI setup) I'm fine with the change. |
fnagel
approved these changes
Jun 4, 2021
Member
fnagel
left a comment
There was a problem hiding this comment.
+1 by reading
Looks good expect for one thing (the removed x variable). Amazing how many formatting issues have been fixed, even though there have been CGL tests in place...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The work is divided into three commits with (mostly, there are exceptions) the following work:
strictrule.Previously, while JSCS was only running in the build process in the command line, JSHint was also running in TestSwarm. There's no official ESLint version running in the browser so I opted to drop this feature; Core doesn't use it and I don't think it's important enough to hold off the switch to ESLint; you will get nice feedback when building in the terminal anyway. Please let me know if that's not acceptable for some reason.