Skip to content

Merging attributes page into Manipulating Elements #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Merging attributes page into Manipulating Elements #713

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88d1fc7
Spaced out the description and added in the getter/setter sentence fr…
May 4, 2016
3992b07
Changed terminology to set/setting, added example for getting a singl…
May 4, 2016
2693e10
Removed attributes markdown file
May 4, 2016
d4c168a
Moved the function syntax text down to sit next to the code example
May 4, 2016
12a85a8
Added a link to the .attr API page and removed line spacing
May 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions page/using-jquery-core/attributes.md
View file
Open in desktop

This file was deleted.

18 changes: 14 additions & 4 deletions page/using-jquery-core/manipulating-elements.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,23 +132,33 @@ myList.append( myItems.join( "" ) );

## Manipulating Attributes

jQuery's attribute manipulation capabilities are extensive. Basic changes are simple, but the `.attr()` method also allows for more complex manipulations. It can either set an explicit value, or set a value using the return value of a function. When the function syntax is used, the function receives two arguments: the zero-based index of the element whose attribute is being changed, and the current value of the attribute being changed.
jQuery's attribute manipulation capabilities are extensive.
Basic changes are simple, but the `.attr()` method also allows for more complex manipulations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this line and the next can be combined with the previous one. I'm not sure we need break lines in between.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @AurelioDeRosa on this one


The `.attr()` method acts as both a getter and a setter. As a setter, `.attr()` can accept either a key and a value, or an object containing one or more key/value pairs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can link back to the relevant page of the API?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AurelioDeRosa good point! I agree that would be useful


```
// Manipulating a single attribute.
// Setting a single attribute.
$( "#myDiv a:first" ).attr( "href", "newDestination.html" );
```

```
// Manipulating multiple attributes.
// Getting a single attribute.
$( "a" ).attr( "href" ); // Returns the href for the first a element in the document
```

```
// Setting multiple attributes.
$( "#myDiv a:first" ).attr({
href: "newDestination.html",
rel: "nofollow"
});
```

When the function syntax is used, the function receives two arguments: the zero-based index of the element whose attribute is being changed, and the current value of the attribute being changed:

```
// Using a function to determine an attribute's new value.
// Using a function to set an attribute's new value.
$( "#myDiv a:first" ).attr({
rel: "nofollow",
href: function( idx, href ) {
Expand Down