Fieldsets nested with django-entangled #361
Conversation
|
I'm not that convinced, that this is a good approach. Until Cascade<1.0 indeed, many multi-widgets extended over a single row. Now they extend vertically. This in my opinion is quite useful for editors working with narrow screens. Look at this example, the window size is 1280 pixels which is quite large:
It simply would be impossible to render all those select fields in one row, unless you have an ultra-wide screen. And wrapping is even more ugly. Your pull request however made me think about the labels inside the select fields. If we proceed with your proposal, then labeling them "Inherit from above" doesn't make sense. Having "Inherit from left" also seems inappropriate. I therefore relabled them to "Inherit from ". This at least makes the arrangement of fields independent, at the cost that now they even got wider. I'm interested about your opinion. |
|
I think once the concept of breakpoints acquired, texts are superfluous in view of recurrence. |
|
My preference is ergonomics because they are fields that come back very often.
|
|
hmm, probably you are right. |
|
Great ! I will prepare that. I will first make the PR for #362, because this could be more efficient than the |
|
PR transferted to #365 |
Related: #358 jrief/django-entangled#3
The test passes here: https://travis-ci.org/haricot/djangocms-cascade/builds/615499744
When the modal is not maximizing the forms displays as before.
I also had to modify the sytles of the breackpoints a little so that they display closer to their checkboxes when they are maximzed. They display a little differently when they are not maximized, but this can be remedied if needed.