задача 3.1 не доделана, не проходит 1 тест. задачи 3.2-3.3 выполнены #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Проверьте, пожалуйста, ваше решение, не все тесты прошли (PR не будет принят до тех пор, пока все добавленные задачи не будут решены). |
|
Добавляю преподавателя (@ufocoder) для код-ревью. |
ufocoder
reviewed
Feb 5, 2025
| @@ -4,5 +4,9 @@ | |||
| * @returns {object | undefined} - returns new object or undefined if nothing did't pass | |||
| */ | |||
| export function invertObj(obj) { | |||
| if (obj === undefined) | |||
ufocoder
reviewed
Feb 5, 2025
| if (string[i] === string[i-1]) { | ||
| n++; | ||
| } | ||
| else n = 1; |
There was a problem hiding this comment.
лучше не опускать скобки в if/else для повышения читаемости
ufocoder
reviewed
Feb 5, 2025
| const arr = path.split('.'); | ||
|
|
||
| return function(obj) { | ||
| if (!obj.hasOwnProperty(arr[0])) return ; |
There was a problem hiding this comment.
Почему проверка идет только для первого элемента? Кажется что это условие можно опустить, у вас ниже похожая работа но в reduce
ufocoder
approved these changes
Feb 5, 2025
ufocoder
reviewed
Feb 5, 2025
|
|
||
| const arr = Object.entries(obj); | ||
| return Object.fromEntries(arr.map(([keys,values])=>[values,keys])); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
прошу проверять со всей строгостью
Задачи 3.2-3.4 выполнены.
Задача 3.1 не доделана не проходит 1 тест. Не успела доделать. Завтра не успеваю доделать, т.к. работаю.
Можно ли доделать к следующему уроку?