Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DOTNET_SKIP_FIRST_TIME_EXPERIENCE with DOTNET_NOLOGO #1692

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Mar 1, 2025

Replace DOTNET_SKIP_FIRST_TIME_EXPERIENCE with DOTNET_NOLOGO in GitHub Actions, based on the guidance at https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-environment-variables#dotnet_skip_first_time_experience:

This environment variable is no longer supported in .NET Core 3.0 and later. Use DOTNET_NOLOGO as a replacement.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.64%. Comparing base (7eec5ca) to head (d204ffd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
- Coverage   90.64%   90.64%   -0.01%     
==========================================
  Files         355      355              
  Lines       11567    11566       -1     
  Branches     1908     1908              
==========================================
- Hits        10485    10484       -1     
  Misses        706      706              
  Partials      376      376              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review March 1, 2025 08:33
@bkoelman bkoelman merged commit 42a010a into master Mar 1, 2025
16 checks passed
@bkoelman bkoelman deleted the replace-DOTNET_SKIP_FIRST_TIME_EXPERIENCE branch March 1, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant