Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
dataChangeCallback
's type parameter isunknown
:After this change, if you construct
Jsf
manually, you get the correct type:This (unfortunately) only works for manual construction because it is impossible (AFAIK) for
HTMLElementTagNameMap
to have a generic that can infer its usage like as below:However, manual construction is fine for frameworks like Solid (tested in my project - IDK about others).
As an aside, I see #14 and wouldn't mind trying to take a crack at fixing some of the TS and/or CICD issues.