-
-
Notifications
You must be signed in to change notification settings - Fork 308
Reference ECMAScript 11.0 specifically (#821) #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d like to encourage a better PR title.
@ssilverman Good suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is in the scope of this PR, but as I noted in #821, we also need to be specific about the flags the RegExp is built with: The u
flag changes how backslash escapes work, but is necessary for Unicode support.
Sure, makes sense to me. I'll make a change. |
@awwright I've pushed a new commit which notes that regular expression SHOULD be built with support for unicode as per defined in ECMA 262. If you approve of this change, we can merge this! |
599d391
to
23919c1
Compare
23919c1
to
d74ddb4
Compare
The above commit mess is brought to you by "Using caps in your branch names!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the PR title to reference "11th edition" instead of the 10th.
The commit message also references 10 (presumably a rebase and rewording will be done after all reviewing is complete?) |
I guess so, but I don't usually. But OK. |
Given the unicode issue is now resolved. I'll consider this OK to merge once automated checks are complete. |
Fixes #821
Reference specific version of emca262.