-
-
Notifications
You must be signed in to change notification settings - Fork 292
Fix mobile navigation overflow #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix mobile navigation overflow #1811
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Hii @benjagm & @Utkarsh-123github, can you please review this PR. Thanks |
Hi @vtushar06 , before I review this PR, it would be great if you please fix this failing check. |
yes @Utkarsh-123github, I tried fixing it, and can you help me out in fixing that. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 30
Lines ? 633
Branches ? 196
========================================
Hits ? 633
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@Utkarsh-123github can you take a look into this, if in case any more changes required. |
great job, LGTM👍 |
Thanks @idanidan29👍 |
What kind of change does this PR introduce?
Bugfix - Fixed mobile navigation overflow issue and improved accordion behavior
Issue Number:
Screenshots/videos:
Responsivenes.bug.on.Mobileview.port.mp4
Updated.Sidebar.mp4
If relevant, did you update the documentation?
Summary
This PR fixes the mobile responsiveness issue reported in #1797 where the left navigation drawer's dropdown menus were overflowing from their parent container on mobile devices, breaking the layout and negatively impacting user experience.
Key changes made:
pathWtihoutFragment
topathWithoutFragment
throughout the componenthandleAccordion
function to ensure only one navigation section can be open at a timeDoes this PR introduce a breaking change?
No, this is a backward-compatible fix that only improves the existing navigation behavior without changing any APIs or interfaces.
Checklist
Please ensure the following tasks are completed before submitting this pull request.