Skip to content

Conversation

@andrew-coleman
Copy link
Member

Truncating the fractional part of the argument is consistent with the behaviour of other functions expecting integer arguments (e.g. substring)

Resolves #717

Copy link
Member

@mattbaileyuk mattbaileyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattbaileyuk mattbaileyuk merged commit 09dba37 into master Jan 14, 2025
8 checks passed
@mattbaileyuk mattbaileyuk deleted the pad branch January 14, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$pad Function With Non-Integer Width Results in Uncaught RangeError

3 participants