Skip to content
This repository was archived by the owner on Jun 12, 2026. It is now read-only.

chore: reconcile repo with published v1.2.1#523

Merged
thomasdavis merged 1 commit into
masterfrom
chore/reconcile-1.2.1
Jun 5, 2026
Merged

chore: reconcile repo with published v1.2.1#523
thomasdavis merged 1 commit into
masterfrom
chore/reconcile-1.2.1

Conversation

@thomasdavis

@thomasdavis thomasdavis commented Jun 5, 2026

Copy link
Copy Markdown
Member

Summary

Reconciles the repo's package.json version with the published npm artifact. The published @jsonresume/schema is at v1.2.1 (published 2024-08-06) while package.json on master HEAD still read 1.1.2. This PR bumps package.json 1.1.2 -> 1.2.1 so the source-of-truth version matches what is actually on npm.

Refs #522, jsonresume/jsonresume.org#275.

What was published vs. what's in the repo (evidence)

I downloaded npm pack @jsonresume/schema@1.2.1 and compared every published file against repo HEAD (50798e3). SHA256 results:

File npm v1.2.1 vs repo HEAD
schema.json identical
job-schema.json identical
sample.resume.json identical
sample.job.json identical
validator.js identical
README.md identical
LICENSE.md identical
package.json differs only in version (1.2.1 vs 1.1.2)

The published v1.2.1 contains no schema changes relative to repo HEAD. The entire delta is the one version string this PR updates. After this change the repo package.json is byte-identical to the published one.

Root cause of the drift

.github/workflows/main.yml runs cycjimmy/semantic-release-action on push. semantic-release computes the next version from conventional commits, publishes to npm and creates a git tag, but with the default config it does not commit the bumped package.json back to the branch. So:

  • The v1.2.1 git tag exists and points at the same commit as HEAD (50798e3), yet package.json at that tag still reads 1.1.2.
  • There is no v1.1.2 git tag at all, even though HEAD's package.json claims 1.1.2.

In other words the in-repo version field has never tracked npm — it is bumped only in the publish pipeline, not in the tree. This PR fixes the current drift; a durable fix (have semantic-release's git plugin commit the bump back, or drop the in-repo version reliance) is a separate follow-up and is best decided by the maintainer.

Verification

npm pack @jsonresume/schema@1.2.1        # fetch published artifact
# SHA256 of all 8 files compared: only package.json differs
diff npm/package/package.json repo/package.json   # => only "version" line
# after edit:
diff npm/package/package.json repo/package.json   # => identical, no output

No npm publish and no schema changes are performed by this PR.

Summary by CodeRabbit

  • Chores
    • Updated JSON Resume schema dependency to version 1.2.1.

The npm package @jsonresume/schema was published at v1.2.1 (2024-08-06)
but package.json on master still read 1.1.2. semantic-release publishes
and tags from CI without committing the version bump back to the repo,
so the source-of-truth version drifted behind npm.

Verified the only delta between npm v1.2.1 and repo HEAD is the version
string: schema.json, job-schema.json, sample.resume.json, sample.job.json,
validator.js, README.md and LICENSE.md are all byte-identical (SHA256).

This bumps package.json 1.1.2 -> 1.2.1 to match the published artifact.

Refs #522, jsonresume/jsonresume.org#275
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 55b81d17-a250-4ae5-b082-2c16f987655c

📥 Commits

Reviewing files that changed from the base of the PR and between 50798e3 and 63aa369.

📒 Files selected for processing (1)
  • package.json

Walkthrough

The package.json version field was updated from 1.1.2 to 1.2.1, reflecting a release bump. This is a straightforward metadata change with no logic or dependency updates.

Changes

Package Version Release

Layer / File(s) Summary
Package version bump
package.json
Version field updated from 1.1.2 to 1.2.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Poem

🐰 A number change, so small yet bright,
From one-one-two to one-two-one in sight,
The schema hops to its newest way,
A minor bump brings the fresh new day! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: reconciling the repository version with the published v1.2.1 release, which matches the single-file package.json version bump from 1.1.2 to 1.2.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/reconcile-1.2.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thomasdavis thomasdavis merged commit f08cffb into master Jun 5, 2026
4 of 8 checks passed
@thomasdavis thomasdavis deleted the chore/reconcile-1.2.1 branch June 5, 2026 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant