chore: reconcile repo with published v1.2.1#523
Conversation
The npm package @jsonresume/schema was published at v1.2.1 (2024-08-06) but package.json on master still read 1.1.2. semantic-release publishes and tags from CI without committing the version bump back to the repo, so the source-of-truth version drifted behind npm. Verified the only delta between npm v1.2.1 and repo HEAD is the version string: schema.json, job-schema.json, sample.resume.json, sample.job.json, validator.js, README.md and LICENSE.md are all byte-identical (SHA256). This bumps package.json 1.1.2 -> 1.2.1 to match the published artifact. Refs #522, jsonresume/jsonresume.org#275
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe package.json version field was updated from 1.1.2 to 1.2.1, reflecting a release bump. This is a straightforward metadata change with no logic or dependency updates. ChangesPackage Version Release
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Reconciles the repo's
package.jsonversion with the published npm artifact. The published@jsonresume/schemais at v1.2.1 (published 2024-08-06) whilepackage.jsononmasterHEAD still read 1.1.2. This PR bumpspackage.json1.1.2->1.2.1so the source-of-truth version matches what is actually on npm.Refs #522, jsonresume/jsonresume.org#275.
What was published vs. what's in the repo (evidence)
I downloaded
npm pack @jsonresume/schema@1.2.1and compared every published file against repo HEAD (50798e3). SHA256 results:schema.jsonjob-schema.jsonsample.resume.jsonsample.job.jsonvalidator.jsREADME.mdLICENSE.mdpackage.jsonversion(1.2.1vs1.1.2)The published v1.2.1 contains no schema changes relative to repo HEAD. The entire delta is the one version string this PR updates. After this change the repo
package.jsonis byte-identical to the published one.Root cause of the drift
.github/workflows/main.ymlrunscycjimmy/semantic-release-actionon push. semantic-release computes the next version from conventional commits, publishes to npm and creates a git tag, but with the default config it does not commit the bumpedpackage.jsonback to the branch. So:v1.2.1git tag exists and points at the same commit as HEAD (50798e3), yetpackage.jsonat that tag still reads1.1.2.v1.1.2git tag at all, even though HEAD'spackage.jsonclaims1.1.2.In other words the in-repo
versionfield has never tracked npm — it is bumped only in the publish pipeline, not in the tree. This PR fixes the current drift; a durable fix (have semantic-release's git plugin commit the bump back, or drop the in-repo version reliance) is a separate follow-up and is best decided by the maintainer.Verification
No npm publish and no schema changes are performed by this PR.
Summary by CodeRabbit