Skip to content

Commit

Permalink
update README and fix validation
Browse files Browse the repository at this point in the history
  • Loading branch information
jstet committed Aug 3, 2024
1 parent a791758 commit e5758c8
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 6 deletions.
14 changes: 12 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,25 @@ The motivation behind this project is to provide an overview of organizations th

The content of data4good.work is managed with static files that are part of the folder `src/lib/data/organizations`.

### Edit Organization

1. To edit an organizations, first complete the dev setup described above and depending on your access rights fork this repo or create a branch.

2. Then go to the corresponding foler and make the change.

3. After making your changes, test them with `npm run dev` and open a PR that one of the admins will review and merge.

### Add Organization

1. To add organizations, first complete the dev setup described above and depending on your access rights fork this repo or create a branch.

2. Then you can either add files manually, or run a script:
2. Then you can either add files manually (simply copy an exising file and adjust the values), or run a script that will prompt you to provide necessary data and create the file automatically:

```
node scripts/add_org.js
```

3. After adding organizations, open a PR that one of the admins will review and merge.
3. After adding organizations, test your changes with `npm run dev` and open a PR that one of the admins will review and merge.



Expand Down
2 changes: 1 addition & 1 deletion src/lib/data/organizations/de/giz_data_lab.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"remote_possible": false,
"initiative_application_possible": null,
"type": {
"framework": "Governmental",
"framework": "Non-Profit",
"emphasis": "Cause-Focused"
},
"working_languages": ["de"]
Expand Down
2 changes: 1 addition & 1 deletion src/lib/data/organizations/mex/prosperia.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"initiative_application_possible": null,
"type": {
"framework": "For-Profit",
"emphasis": "Product Focused"
"emphasis": "Product-Focused"
},
"working_languages": ["es"]
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/data/organizations/us/development_data_lab.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"initiative_application_possible": null,
"type": {
"framework": "Non-Profit",
"emphasis": "Cause Focused"
"emphasis": "Cause-Focused"
}
}

1 change: 0 additions & 1 deletion src/lib/parsing/validation.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export const validateLanguage = (value) => {
return 'Must be 2 characters';
}
try {
console.log(validateLanguageCode(value), value);
validateLanguageCode(value);
return true;
} catch (e) {
Expand Down

0 comments on commit e5758c8

Please sign in to comment.