chore: standardise Cargo.toml files #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit standardises all Cargo.toml files. We use workspace dependencies for *true* workspace dependencies. Crates within the workspace are referred to using their path.
This was referenced Aug 15, 2024
zcabter
reviewed
Aug 16, 2024
| http.workspace = true | ||
| in-container.workspace = true | ||
| indicatif.workspace = true | ||
| jstz_api = { path = "../jstz_api" } |
There was a problem hiding this comment.
Out of curiosity, why can't we refer to internal crates with .workspace?
There was a problem hiding this comment.
Since we rely on .workspace to differentiate between external dependencies and internal crates.
We rely on this in #542 when building all the workspace dependencies (cargoDeps). If we don't have this distinction, then we'd essentially get cache misses each time, as the workspace dependencies would include all internal crates (which change in almost every PR)
|
Build and tested locall ✅ |
zcabter
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Description
This PR
In the future it would be nice to use
cargo-sortand have a CI check to keep it consistent but currently it Sort [workspace.dependencies], [workspace.dev-dependencies], and [workspace.build-dependencies] DevinR528/cargo-sort#54flake.nix, addingchecksandformatter#542 )In future,
Cargo.toml(unless not supported as a workspace dependencies, such as optional dependencies){ path = <crate path> }Manually testing the PR
Check everything builds and passes tests :)
make build make test