Add Eslint #4
Open
Add Eslint #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddie-atkinson
commented
Sep 5, 2024
| for (const parcel of event.applicableParcels) { | ||
| const currentParcel = currentHoldings[parcel.id]; | ||
| if (!currentParcel) decorations.errors.push(`Parcel ${parcel.id} did not exist at the sale date`); | ||
| else if (currentParcel.asxCode !== event.asxCode) { |
There was a problem hiding this comment.
Here is where I added the curlies, happy to revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds eslint and some default VSCode config. There are quite a few failing rules, in almost all cases I ignored them instead of fixing them. In one or two cases I added some curly braces around
ifandelsestatements that were complaining.In general I'm not keen to fix these issues until we get tests in and Typescript, which should both help to reduce the risk of breaking everything.