feat: allow onSuccessFunction/onFailFunction to be a promise #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for a great SR plug-in 🙏
It is seeing heavy usage in a corporate environment I work in, where I also ran into the issue that I'd like to asynchronously build the template using this library. However if for instance
onSuccessFunctionis a Promise, theslackMessageisn't awaited, resulting in aPromise { <pending> }being offered to the Slack API and of course this results inSemanticReleaseError: invalid_payload.await Promise.resolve()wrappers for bothonSuccessFunction&onFailFunctionshould allow us to input both Promises and sync functions.If you have any thoughts please let me know!