Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for vector-valued objective functions #497

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Add support for vector-valued objective functions #497

merged 4 commits into from
Feb 13, 2023

Conversation

odow
Copy link
Member

@odow odow commented Jan 10, 2023

@odow odow mentioned this pull request Jan 10, 2023
Merged
odow
odow commented Jan 10, 2023
View reviewed changes
test/MOI/MOI_multiobjective.jl
@@ -55,7 +55,7 @@ c4: y >= 0.25
@test MOI.get(model, Gurobi.MultiObjectivePriority(2)) == 0

MOI.optimize!(model)
@test MOI.get(model, MOI.ObjectiveValue()) ≈ 1.5
@test MOI.get(model, MOI.ObjectiveValue()) ≈ [1.5, 2.0]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change (albeit, a minor one for someone using the multi-objective interface to Gurobi)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blegat: this is a good enough time as any to release a Gurobi v1.0.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we plan any more breaking changes so I don't see any objection

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I'll merge and then make a few other changes before tagging Gurobi v1.0

@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Base: 90.12% // Head: 90.61% // Increases project coverage by +0.48% 🎉

Coverage data is based on head (7b8636f) compared to base (3ee3e37).
Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   90.12%   90.61%   +0.48%     
==========================================
  Files           5        5              
  Lines        2379     2407      +28     
==========================================
+ Hits         2144     2181      +37     
+ Misses        235      226       -9
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 89.85% <93.33%> (+0.18%) ⬆️
src/MOI_wrapper/MOI_multi_objective.jl 95.45% <100.00%> (+9.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow mentioned this pull request Jan 22, 2023
Merged
@odow odow force-pushed the od/vector-optimization branch from 830e982 to 7b8636f Compare February 10, 2023 23:20
@odow odow changed the title WIP: begin support for vector-valued objective functions Add support for vector-valued objective functions Feb 10, 2023
@odow odow marked this pull request as ready for review February 10, 2023 23:22
@odow odow merged commit e8423f8 into master Feb 13, 2023
@odow odow deleted the od/vector-optimization branch February 13, 2023 20:31
@odow odow mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @blegat