-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Containers] add support for view of DenseAxisArray #3152
Conversation
Codecov ReportBase: 97.70% // Head: 97.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3152 +/- ##
==========================================
+ Coverage 97.70% 97.72% +0.01%
==========================================
Files 33 33
Lines 4485 4522 +37
==========================================
+ Hits 4382 4419 +37
Misses 103 103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Okay. I fixed the |
Closes #3151
Part of #2998 (still to do SparseAxisArray?)
I'm not overly convinced of this approach. I felt I was just poking methods until things were working. For something like
D[I] .= 1.0
, Base uses a weird dispatch downdotview
andmaybeview
.I should add more tests before merging, and consider also SparseAxisArray.
There's also a question: should you be able to access a value that isn't in the view, but is in the underlying array?