Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Containers] add support for view of DenseAxisArray #3152

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Dec 15, 2022

Closes #3151
Part of #2998 (still to do SparseAxisArray?)

I'm not overly convinced of this approach. I felt I was just poking methods until things were working. For something like D[I] .= 1.0, Base uses a weird dispatch down dotview and maybeview.

I should add more tests before merging, and consider also SparseAxisArray.

There's also a question: should you be able to access a value that isn't in the view, but is in the underlying array?

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 97.70% // Head: 97.72% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (3856b82) compared to base (ed3dc0f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3152      +/-   ##
==========================================
+ Coverage   97.70%   97.72%   +0.01%     
==========================================
  Files          33       33              
  Lines        4485     4522      +37     
==========================================
+ Hits         4382     4419      +37     
  Misses        103      103              
Impacted Files Coverage Δ
src/Containers/DenseAxisArray.jl 95.86% <100.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow requested a review from blegat January 2, 2023 00:45
@odow
Copy link
Member Author

odow commented Jan 3, 2023

Okay. I fixed the getindex problem to respect the new axes, changed eachindex to be lazy, and added a couple more tests.

@odow odow merged commit 9f61e95 into master Jan 5, 2023
@odow odow deleted the od/dense-view branch January 5, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

DenseAxisArray with Symbol key does not support setting
2 participants