[Utilities] improve performance of canonical #1704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial analysis of jump-dev/JuMP.jl#2817
No changes to the memory allocations. But
canonical
gets called an awful lot, so this is a critical path. The current implementation was very generic with dynamic dispatch. But the functions aren't used outside MOI, or anywhere else in MOI:https://juliahub.com/ui/Search?q=sort_and_compress%21&type=code
https://juliahub.com/ui/Search?q=is_strictly_sorted&type=code
Script:
Before
After