Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all linear indicator constraints in the Utilities.Model #2618

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

matbesancon
Copy link
Contributor

@matbesancon matbesancon commented Feb 9, 2025

For some reason only indicator less than was added to MOI.Utilities.Model, which prevents copying models with that constraint

@joaquimg
Copy link
Member

joaquimg commented Feb 9, 2025

We should consider a copy test with all constraint types.

@matbesancon
Copy link
Contributor Author

can we do that in a separate PR? I'd love to avoid growing my infamous PR scope explosion legend

@odow
Copy link
Member

odow commented Feb 9, 2025

can we do that in a separate PR? I'd love to avoid growing my infamous PR scope explosion legend

Yes, I can do this. 👍 for no scope explosion.

which prevents copying models with that constraint

Can you clarify the use-case? You probably want to copy to MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}())

@odow odow merged commit 33976af into jump-dev:master Feb 9, 2025
15 checks passed
@odow
Copy link
Member

odow commented Feb 9, 2025

I just added a test here #2619

@matbesancon
Copy link
Contributor Author

Can you clarify your use case?

Yes indeed in my case using the universal fallback on top works, but it seems odd to need it on top of MOIU.Model given the description of the latter:

An implementation of ModelLike that supports all functions and sets defined in MOI. It is parameterized by the coefficient type.

@matbesancon matbesancon deleted the add-all-indicator branch February 10, 2025 14:21
@odow
Copy link
Member

odow commented Feb 10, 2025

Haha yeah it's "supports almost all functions and sets"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants