fix(core): carousel slides order render #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
felipefialho
changed the title
felipefialho
approved these changes
Dec 28, 2023
tiago-dela-rosa
approved these changes
Dec 28, 2023
gabrielduete
approved these changes
Dec 28, 2023
Merged
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
The order that the carousel slides were rendered was wrong. This PR fix it passing the responsability of remove slide wrapper to parent.
What impacts?
Carousel component takes the responsability to normalize the slides.
Reversal plan
Describe which plan we should follow if this delivery has to be reversed.
Evidences
Media(images, gifs or videos) that shows the result of your work.