feat: add font size prop into icon component #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
felipefialho
previously approved these changes
Feb 9, 2024
mauriciomutte
previously approved these changes
Feb 9, 2024
matheus-rosa-jsm
dismissed stale reviews from mauriciomutte and felipefialho
via
11e0fa8
felipefialho
approved these changes
Feb 14, 2024
mauriciomutte
approved these changes
Feb 14, 2024
This was referenced Feb 14, 2024
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
Change size prop into icon component to set font-size style value. This component use font-size css to do this customization as recommended by ionic icon
What impacts?
Alternative prop to customize icon size with specific values
Reversal plan
Describe which plan we should follow if this delivery has to be reversed.
Evidences