Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): remove wrong width on icon size #414

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

felipefialho
Copy link
Contributor

@felipefialho felipefialho commented Apr 11, 2024

Infos

What is being delivered?

  • Remove the wrong width
  • Remove unnecessary margin-top

What impacts?

This width was flattening the icon wrongly

Evidences

Before
image

After
image

@felipefialho felipefialho added bug Something isn't working components labels Apr 11, 2024
@felipefialho felipefialho self-assigned this Apr 11, 2024
mauriciomutte
mauriciomutte previously approved these changes Apr 11, 2024
Copy link
Contributor

github-actions bot commented Apr 11, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-11 21:29 UTC

@felipefialho felipefialho merged commit e45007c into main Apr 11, 2024
2 checks passed
@felipefialho felipefialho deleted the fix/alert-icon-size branch April 11, 2024 21:27
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants