Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): add new carousel component #434

Merged
merged 12 commits into from
May 13, 2024
Merged

Conversation

felipefialho
Copy link
Contributor

Infos

Task

What is being delivered?

  • Add a new carousel component
  • Move the old carousel as deprecated carousel

What impacts?

It PR refactoring completely the carousel component, so it will be necessary to change the way the carousel is used in the project. So we keep for now the old carousel as deprecated carousel, using as <atom-deprecated-carousel> to keep the old carousel working.

After refactoring the old carousel inside project (it will be called CarouselShowcase), we will be able to remove the deprecated carousel here.

advantages:

  • The new carousel will be more flexible and easier to use 🥇
  • Use just vanilla JS, so it will be easier to maintain 🚀
  • The size of the bundle will be reduced as 420kb to 16kb (96% less) 😱
 {
    "key": "atom-carousel.entry",
    "components": [
       "atom-carousel"
     ],
     "originalByteSize": 16677
},
{
  "key": "atom-carousel-item.entry",
  "components": [
    "atom-carousel-item"
    ],
  "originalByteSize": 8993
},
{
  "key": "atom-deprecated-carousel.entry",
  "components": [
    "atom-deprecated-carousel"
    ],
    "originalByteSize": 417647
},
{
  "key": "atom-deprecated-carousel-item.entry",
    "components": [
      "atom-deprecated-carousel-item"
    ],
    "originalByteSize": 9022
},

Evidences

image

@felipefialho felipefialho added dependencies Pull requests that update a dependency file package/core improvements labels May 10, 2024
@felipefialho felipefialho self-assigned this May 10, 2024
Copy link
Contributor

github-actions bot commented May 10, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-13 17:19 UTC

Copy link
Contributor

@igorwessel igorwessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@felipefialho felipefialho merged commit e246629 into main May 13, 2024
2 checks passed
@felipefialho felipefialho deleted the refactor/carousel branch May 13, 2024 17:17
@github-actions github-actions bot mentioned this pull request May 13, 2024
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvements package/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants