-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(carousel): add new carousel component #434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MayaraRMA
reviewed
May 10, 2024
MayaraRMA
reviewed
May 10, 2024
MayaraRMA
reviewed
May 10, 2024
MayaraRMA
reviewed
May 10, 2024
SallesCosta
reviewed
May 13, 2024
igorwessel
reviewed
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
packages/core/src/components/carousel/stories/carousel.core.stories.tsx
Outdated
Show resolved
Hide resolved
igorwessel
approved these changes
May 13, 2024
SallesCosta
approved these changes
May 13, 2024
gabrielduete
approved these changes
May 13, 2024
MayaraRMA
approved these changes
May 13, 2024
Merged
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
What impacts?
It PR refactoring completely the carousel component, so it will be necessary to change the way the carousel is used in the project. So we keep for now the old carousel as deprecated carousel, using as
<atom-deprecated-carousel>
to keep the old carousel working.After refactoring the old carousel inside project (it will be called CarouselShowcase), we will be able to remove the deprecated carousel here.
advantages:
Evidences