feat(component): create link component #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
tassioFront
commented
Jul 30, 2024
tassioFront
commented
Jul 30, 2024
tassioFront
commented
Jul 30, 2024
tassioFront
commented
Jul 30, 2024
tassioFront
requested review from
felipefialho,
MayaraRMA,
jowjow22 and
igorwessel
jowjow22
approved these changes
Jul 30, 2024
felipefialho
changed the title
igorwessel
approved these changes
Jul 30, 2024
felipefialho
approved these changes
Jul 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Creating an atom-link component to be used combined with router components (such as Link, router-link and NuxtLink). Ideally, atom-link takes care of styling as router components work differently. This means we keep needing to import them when creating new anchor links.
Task
What is being delivered?
Link component and its stories
What impacts?
Link components can be used on the projects. Available to test utilizing the version 2.10.0-alpha.2
Reversal plan
Describe which plan we should follow if this delivery has to be reversed.
Evidences
React
link-Link.webm
link-btn.webm
Vue
link-nuxtlink.webm
link-button.webm