fix(tokens)!: fix all letter spacing values #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
felipefialho
previously approved these changes
Aug 16, 2024
lupy100
previously approved these changes
Aug 16, 2024
mauriciomutte
previously approved these changes
Aug 16, 2024
Natalie9
dismissed stale reviews from mauriciomutte, lupy100, and felipefialho
via
e5d1728
tassioFront
reviewed
Aug 16, 2024
felipefialho
changed the title
tassioFront
previously approved these changes
Aug 16, 2024
gabrielduete
previously approved these changes
Aug 16, 2024
felipefialho
previously approved these changes
Aug 19, 2024
mauriciomutte
previously approved these changes
Aug 20, 2024
Natalie9
dismissed stale reviews from mauriciomutte, felipefialho, gabrielduete, and tassioFront
via
d862eb9
Natalie9
requested review from
felipefialho,
mauriciomutte,
tassioFront and
gabrielduete
tassioFront
requested changes
Aug 27, 2024
felipefialho
requested changes
Aug 27, 2024
Natalie9
force-pushed
the
fix/tokens-letter-spacing-value
branch
2 times, most recently
from
1d6a995 to
e1aa18c
Compare
tassioFront
reviewed
Aug 30, 2024
Natalie9
force-pushed
the
fix/tokens-letter-spacing-value
branch
from
908e94a to
a16a0a5
Compare
MayaraRMA
reviewed
Sep 9, 2024
tassioFront
approved these changes
Sep 9, 2024
felipefialho
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
The value of the
letter-spacingvariables was incorrectly converted from%toem. The corresponding correction was made, whereWhat impacts?
All fonts in all applications.
Reversal plan
Rollback this PR
Evidences
Before
letter-spacing: 0.0004em== 0.04%After
letter-spacing: 0.04em== 4%Desing System