feat(select): add badge in select options #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Natalie9
force-pushed
the
feat/slots-in-select
branch
from
d275f4b to
9740638
Compare
felipefialho
requested changes
Aug 30, 2024
felipefialho
requested changes
Aug 30, 2024
There was a problem hiding this comment.
@Natalie9 We also need to add more things inside description, like prints screens and etc
tassioFront
reviewed
Aug 30, 2024
|
It missing a space here:
|
@tassioFront |
felipefialho
requested changes
Sep 3, 2024
packages/core/src/components/select/stories/select.core.stories.tsx
Outdated
Show resolved
Hide resolved
felipefialho
requested changes
Sep 3, 2024
packages/core/src/components/select/stories/select.core.stories.tsx
Outdated
Show resolved
Hide resolved
felipefialho
requested changes
Sep 3, 2024
packages/core/src/components/select/stories/select.react.stories.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/select/stories/select.vue.stories.tsx
Outdated
Show resolved
Hide resolved
igorwessel
requested changes
Sep 3, 2024
packages/core/src/components/select/stories/select.react.stories.tsx
Outdated
Show resolved
Hide resolved
felipefialho
reviewed
Sep 3, 2024
tassioFront
reviewed
Sep 3, 2024
tassioFront
reviewed
Sep 3, 2024
igorwessel
previously approved these changes
Sep 4, 2024
tassioFront
approved these changes
Sep 9, 2024
jowjow22
approved these changes
Sep 9, 2024
felipefialho
approved these changes
Sep 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
Add a new option to show Badge in select options
What impacts?
Select component
Reversal plan
Return previous version in NPM and rollback this PR
Evidences