Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): dont remove eventlistener on blur/focus #598

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

igorwessel
Copy link
Contributor

@igorwessel igorwessel commented Oct 23, 2024

Infos

Task

What is being delivered?

As we are removing the event listener in the "handleBlur" and "handleFocus" methods, libraries that use these events cannot function correctly after the first activation because we remove the event listener.

What impacts?

  • Input

Reversal plan

  • Revert

Evidences

With fix:

Gravacao.de.Tela.2024-10-31.as.08.52.13.mov

Without fix, current production branch:

Gravacao.de.Tela.2024-10-31.as.08.53.20.mov

Copy link

Quality Gate Passed Quality Gate passed for 'juntossomosmais_atomium_core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Oct 23, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-31 14:17 UTC

@igorwessel igorwessel self-assigned this Oct 23, 2024
@igorwessel igorwessel added bug Something isn't working package/core components labels Oct 23, 2024
@igorwessel igorwessel marked this pull request as ready for review October 31, 2024 11:42
@igorwessel igorwessel requested review from felipefialho, a team, Natalie9, 3rdepaula and jowjow22 and removed request for a team October 31, 2024 11:50
@igorwessel igorwessel merged commit c79b2b1 into main Oct 31, 2024
8 checks passed
@igorwessel igorwessel deleted the fix/not-remove-eventlistener-input branch October 31, 2024 14:15
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working components package/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants