feat(atom-steps-modal): initial step feature #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jowjow22
changed the title
jowjow22
changed the title
jowjow22
requested review from
felipefialho,
tassioFront,
igorwessel and
gabrielduete
anabrook
previously approved these changes
Nov 22, 2024
luiz-ortega
previously approved these changes
Nov 22, 2024
tassioFront
reviewed
Nov 22, 2024
tassioFront
reviewed
Nov 22, 2024
tassioFront
reviewed
Nov 22, 2024
tassioFront
reviewed
Nov 22, 2024
igorwessel
reviewed
Nov 25, 2024
|
|
igorwessel
approved these changes
Nov 25, 2024
felipefialho
approved these changes
Nov 25, 2024
tassioFront
approved these changes
Nov 25, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
adding new property to allow user to start the modal directly in a specific step even though it has more steps behind.
Change the use of primaryButtonText and secondaryButtonText to be an array of string for each step, like the titles.
Change the name of this properties to be more descriptive with the purpose
What impacts?
BREAKING CHANGE: Atom steps modal component and primaryButton and secondaryButton texts functionalities, the primaryButtonText and secondaryButtonText properties don't will exists by now on.
Reversal plan
Re-release of the previous version and revert on main branch.
Evidences
Media(images, gifs or videos) that shows the result of your work.
Gravação de tela de 22-11-2024 11:21:28.webm