You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request includes several changes to the configuration and dependencies of the project, as well as updates to the build process for the React and Vue packages. The most important changes involve updates to the vite.config.js file, dependency versions in package.json, and adjustments to the build configurations for React and Vue.
packages/core/stencil.config.ts: Added a new output target type dist-custom-elements and updated the React output target configuration. Removed the reactBooleanFixOutputTarget configuration. [1][2]
Dependency Updates:
package.json: Updated versions of several dependencies, including @stencil/core, @stencil/react-output-target, and various @storybook packages. [1][2][3]
Build Process Adjustments:
packages/react/package.json: Simplified the build process by consolidating the CommonJS and ESM build steps into a single compile step.
These changes improve the overall configuration and build processes, ensuring that the project stays up-to-date with the latest dependencies and follows best practices for module resolution and output targets.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
felipefialho
dismissed
mauriciomutte’s stale review
Summary
This pull request includes several changes to the configuration and dependencies of the project, as well as updates to the build process for the React and Vue packages. The most important changes involve updates to the
vite.config.jsfile, dependency versions inpackage.json, and adjustments to the build configurations for React and Vue.Configuration Updates:
apps/docs-vue/vite.config.js: Updated the Vite configuration to treat tags with hyphens as custom elements.packages/core/stencil.config.ts: Added a new output target typedist-custom-elementsand updated the React output target configuration. Removed thereactBooleanFixOutputTargetconfiguration. [1] [2]Dependency Updates:
package.json: Updated versions of several dependencies, including@stencil/core,@stencil/react-output-target, and various@storybookpackages. [1] [2] [3]Build Process Adjustments:
packages/react/package.json: Simplified the build process by consolidating the CommonJS and ESM build steps into a single compile step.packages/react/tsconfig.json: Changed the module system toesnextand updated the module resolution tobundler.packages/vue/tsconfig.json: Updated the module resolution tobundler.Code Refactoring:
packages/react/src/index.ts: Adjusted the export path for components.These changes improve the overall configuration and build processes, ensuring that the project stays up-to-date with the latest dependencies and follows best practices for module resolution and output targets.